Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve inline documentation of OAUTH_BASE_URL Issue #54 #55

Merged
merged 4 commits into from
May 17, 2019
Merged

Improve inline documentation of OAUTH_BASE_URL Issue #54 #55

merged 4 commits into from
May 17, 2019

Conversation

chrisjsimpson
Copy link
Contributor

Postmortem:

The OAUTH_BASE_URL was set to the api host, instead of the tester host, and the path /obp was not present.” Do you think the props names are OK and documentation good enough for future deployments?

This improves inline documentation of OAUTH_BASE_URL Issue #54

@chrisjsimpson
Copy link
Contributor Author

@simonredfern Ready 👍 https://github.com/OpenBankProject/API-Tester/pull/55/files

@simonredfern simonredfern merged commit 2bae114 into OpenBankProject:master May 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chrisjsimpson @simonredfern